Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move drafts to experimental #4785

Merged
merged 15 commits into from
Sep 16, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Jul 26, 2024

Closes https://github.com/github/primer/issues/3666

Now that https://github.com/github/primer/issues/3668 has been addressed, we can officially remove drafts from @primer/react 🫡

Changelog

New

Changed

Removed

  • Remove drafts entrypoint in favor of experimental

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

Migration plan

Testing & Reviewing

  • Verify the drafts entrypoint has been removed
  • Verify that no mentions of drafts exists in documentation
  • Verify that experimental continues to match draft entrypoint now that drafts is gone

Copy link

changeset-bot bot commented Jul 26, 2024

🦋 Changeset detected

Latest commit: 086ac50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jul 26, 2024
Copy link
Contributor

github-actions bot commented Jul 26, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.38 KB (-0.06% 🔽)
packages/react/dist/browser.umd.js 97.64 KB (-0.09% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4785 September 12, 2024 16:47 Inactive
@joshblack joshblack marked this pull request as ready for review September 12, 2024 16:48
@joshblack joshblack requested a review from a team as a code owner September 12, 2024 16:48
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trust you with this!

@joshblack joshblack added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit b74c47f Sep 16, 2024
32 checks passed
@joshblack joshblack deleted the refactor/move-drafts-to-experimental-2 branch September 16, 2024 15:32
@primer primer bot mentioned this pull request Sep 16, 2024
TylerJDev pushed a commit that referenced this pull request Sep 23, 2024
* refactor: move drafts to experimental

* chore: add changeset

* refactor: rename drafts to experimental

* chore: remove imports to drafts

* test(e2e): move drafts to experimental

* docs: change drafts to experimental

* chore: update changeset

* chore: update story ids

* docs: update drafts to experimental

* chore: update top-level storybook order

* chore: update banner e2e tests

* chore: update figma file imports

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants